Allow constructors for has_one :through #40007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This is disabled since the feature was introduced 273b21f. I think we should try to enable it. |
|
@rafaelfranca I can add a few more tests based on the other associations. Any other suggestions on things to look out for? Any ideas as to why it wasn't originally included? |
|
That was before my time. I'd say, let's try to improve the test coverage and add an changelog entry. We can release in the 6.2 release. |
perezperret
force-pushed
the
spp-has-one-through-constructable
branch
from
ce9e4d0
to
b220054
Compare
perezperret
force-pushed
the
spp-has-one-through-constructable
branch
from
b220054
to
ac61973
Compare
|
Great! I added some simple tests and a changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I couldn't find any reference to this in the guides or docs, but association constructors for
has_one :throughassociations appear to be disabled. I simply enabled them and used them in the tests and nothing broke, so I'm trying to understand why they should be disabled. I would appreciate some guidance for figuring this out. Also, if there is a good reason for this, or this change is deemed unimportant or unnecessarily risky, I think the docs should be updated to reflect thatbuild_associationandcreate_associationare not available forhas_one :through(I'd be happy to make those changes instead if that's the case).