New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v2.8.1 #1541
Comments
GH Actions need to ensure libyaml-dev is installed if necessary. Also I think it would be useful to include #1534. This is not a regression, but is an issue that can cause random errors. |
Gemfile should probably also be synced with master. I don't think strscan is needed. |
@sebbASF would you consider these essential for a 2.8.1 release? Eventually we can cherry pick anything to a later 2.8.* right? |
Synching Gemfile makes it easier to test, but is not essential. |
👍🏻 I don't see any CI results for the 2-8-stable branch (or I'm overlooking...) - so that seems an important thing to fix right after 2.8.1. |
That's because test.yml only runs for changes to master. But surely it's important to run the checks on 2.8 as well? |
I've added a PR to show that the build does currently work if test.yml is updated |
Saw the PR 🙏🏻 Important indeed. |
This is great @eval |
Please release #1489 is killing me when testing a new rails project setup script. Thank you! |
The change to remove the |
would love to see #1511 released soon if possible! |
I'm struggling to figure out why the gem was not yanked immediately. It is clearly broken and shipping a fix is taking a long time (which is fine, this is OS and we are all doing our best). So why not yank the gem? |
@eval i can set aside some time to help with testing & whatever else is needed to do a release. lmk if that would be useful. |
Please release or yank... rails-lambda/lamby-cookiecutter#25 |
I am an OS maintainer too and I have a lot of empathy for those that run projects. This issue is likely wrecking havoc on folks starting new Rails application across many different spectrums, including my own community. Why the v2.8.0 gem was not yanked immediately is something I do not understand. It's like leaving a bad deploy out there and working the fix under duress vs. doing a revert and thoughtful fix. |
Is there any reason to not limit the release of 2.8.1 to just fixing the file permission issue? It seems to be the most impactful. I'm not familiar with the release process, but hopefully it is not so onerous that we must wait for a larger batch to release. Alternatively, yes, yanking the gem would be appreciated. |
This issue lists several non-backwards compatible problems with v2.8.0 that would cause errors only at 'send-time'. |
yank it then ffs. |
We have a minor issue in the system now because of incorrect file permissions Is there any schedule for 2.8.1 release, please? Do we need to wait or should we rollback to 2.7.1? |
I think we are well past the point of yanking right? Can the team tag v2.8.2 using the same v2.8.1 tag/sha and push a gem with the right file permissions? |
If possible, a htofix with corrected permissions would be really appreciated. Like many others, I ran into this too. A small fix with just the corrected permissions would make my life a lot easier. As a fellow open source maintainer, I understand that life gets in the way and it can take time to issue fixes, of course. I get that you may not have had the time to release anything new. |
Suggestion. Checkout the v2.8.0 tag, change the version to v2.8.0.1, publish a new gem, ensure perms are good. |
It seems like @mikel is busy with other things right now, which is unfortunate for the ones being bitten by the file permissions issue, but 100% ok. We can still work around this by locking mail to 2.7.1. According to RubyGems, @jeremy has the permissions to cut a new release, too. So @jeremy, is it possible that you publish a new minor release of this gem with fixed file permissions? You can just check out the 2.8.0 tag, bump the version and publish. This would help me and probably others a great deal. I don't know how the faulty file permissions got into the current release in the first place, but looking at the Rakefile, there's nothing wrong. It seems to be an issue on the machine used by the original publisher of the 2.8.0 version. Original file permissions issue is here: |
Pushed a 2.8.0.1.rc1 with file perms fixed and no other code changes. @ralph and others, would you please verify? |
@jeremy Thank you very much for you effort. I can confirm that 2.8.0.1.rc1 has the correct file permissions and works flawlessly in our docker based environment. For full reference, here are the file permissions for 2.8.0:
And for 2.8.0.1.rc1:
Also let me add that I had to think of this a lot. So thank you again for contributing to open source. |
Thank you so much, @jeremy! 🙇♀️ ❤️ 👏 |
Thanks for the verification! Pushed 2.8.0.1. |
@eval this works for us, thank you! |
I can also confirm this 2.8.1.rc2 working. (at least for fixing the #1538 rails config issue). Thank you! |
Thanks all for the feedback on the RC! I tagged v2.8.1 and asked Mikel to cut the release. I'll close this issue when the release is available. |
Mikel just released v2.8.1 🎉 Thanks everyone for their input, tests, fixes and patience! 🙏🏻 |
fixing issue mikel/mail#1541
Just to gather the most urgent issues we'd like to tackle for a v2.8.1 release:
This fixes smtp delivery with
enable_starttls_auto: false
.Let me know @mikel and others if I missed any other urgent regressions.
The text was updated successfully, but these errors were encountered: