Skip to content

Commit

Permalink
Removed ubygems.rb. rubygems.rb is always loaded now.
Browse files Browse the repository at this point in the history
  * tool/sync_default_gems.rb: removed ubygems.rb from sync target.
  * test/rubygems/test_gem.rb: only enable "-rubygems" option when
    running under the Ruby 1.9.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
hsbt committed Sep 24, 2017
1 parent 6f968ca commit e5e1f90
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 16 deletions.
1 change: 0 additions & 1 deletion LEGAL
Expand Up @@ -729,7 +729,6 @@ spec/ruby:
OTHER DEALINGS IN THE SOFTWARE.

lib/rubygems.rb:
lib/ubygems.rb:
lib/rubygems:
test/rubygems:

Expand Down
11 changes: 0 additions & 11 deletions lib/ubygems.rb

This file was deleted.

6 changes: 4 additions & 2 deletions test/rubygems/test_gem.rb
Expand Up @@ -1466,8 +1466,9 @@ def test_looks_for_gemdeps_files_automatically_on_start
ENV['RUBYGEMS_GEMDEPS'] = "-"

path = File.join @tempdir, "gem.deps.rb"
cmd = [Gem.ruby.dup.untaint, "-I#{LIB_PATH.untaint}", "-rubygems"]
cmd = [Gem.ruby.dup.untaint, "-I#{LIB_PATH.untaint}"]
if RUBY_VERSION < '1.9'
cmd << "-rubygems"
cmd << "-e 'puts Gem.loaded_specs.values.map(&:full_name).sort'"
cmd = cmd.join(' ')
else
Expand Down Expand Up @@ -1508,8 +1509,9 @@ def test_looks_for_gemdeps_files_automatically_on_start_in_parent_dir
Dir.mkdir "sub1"

path = File.join @tempdir, "gem.deps.rb"
cmd = [Gem.ruby.dup.untaint, "-Csub1", "-I#{LIB_PATH.untaint}", "-rubygems"]
cmd = [Gem.ruby.dup.untaint, "-Csub1", "-I#{LIB_PATH.untaint}"]
if RUBY_VERSION < '1.9'
cmd << "-rubygems"
cmd << "-e 'puts Gem.loaded_specs.values.map(&:full_name).sort'"
cmd = cmd.join(' ')
else
Expand Down
3 changes: 1 addition & 2 deletions tool/sync_default_gems.rb
Expand Up @@ -60,9 +60,8 @@ def sync_default_gems(gem)

case gem
when "rubygems"
`rm -rf lib/rubygems* lib/ubygems.rb test/rubygems`
`rm -rf lib/rubygems* test/rubygems`
`cp -r ../../rubygems/rubygems/lib/rubygems* ./lib`
`cp -r ../../rubygems/rubygems/lib/ubygems.rb ./lib`
`cp -r ../../rubygems/rubygems/test/rubygems ./test`
when "bundler"
`rm -rf lib/bundler* bin/bundler bin/bundle bin/bundle_ruby spec/bundler`
Expand Down

5 comments on commit e5e1f90

@simi
Copy link
Contributor

@simi simi commented on e5e1f90 Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye ubygems! I'll never forget.

@pynixwang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add add add, clean clean clean

@attilagyorffy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny piece of my heart is now broken. Bless you irb -rubygems.

@wilsonsilva
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best code is no code at all. Byyyyyye.

@marcandre
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should deprecate in 2.5 and remove in later version.

Please sign in to comment.