Anonymous Struct literal ${a:1, b:2}
#3259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Jun 25, 2020
|
It's a fun idea. I can see many usage. |
Try to introduce anonymous Struct literal.
${a:1, b:2} is equal to Struct.new(kw.keys).new(kw.values) where
kw is {a:1, b:2}.
If members of literal struct are same and same order, they share same class. Also fix ISeq#to_binary, .load_from_binary.
|
I always wanted something short like this, but do you think we could have something more explicit and verbose like |
nobu
reviewed
Jun 26, 2020
| { | ||
| /*%%%*/ | ||
| $$ = new_struct(p, $3, &@$); | ||
| $$->nd_brace = TRUE; |
There was a problem hiding this comment.
This seems unnecessary, because it is not a NODE_HASH.
|
Please DO NOT discuss spec here. Please write a comment on redmine ticket. |
|
just delegate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to introduce anonymous Struct literal.
https://bugs.ruby-lang.org/issues/16986
${a:1, b:2}is almost equal toStruct.new(kw.keys).new(kw.values)wherekwis{a:1, b:2}.Anonymous class is prepared at compile time.